John Stilley
John Stilley
So, matplotlib released a new version to PyPI.org today. This removed (or changed?) the old color map logic we are using: https://github.com/terrapower/armi/blob/872e2dac316d937d06a9d3a7a314c48075204a2b/armi/utils/reportPlotting.py#L732 You will see `get_cmap()` in [matplotlib==3.7.5](https://matplotlib.org/3.7.5/api/cm_api.html), but not...
I think a Jupyter notebook is a great idea. As long as it has (or comes with) actual test describing things. Working examples are great, when they come with lots...
@albeanth Can you give us a quick run down of the state of this ticket, please? Thanks!
@albeanth I would like to _bump_ this work. It is awkward that we released this software to the NRC while this ticket was still open.
@albeanth @drewj-tp @keckler We have come to believe there will be a lot of work coming up that will require this documentation. For instance, component linking.
> We have a lot of mac users here despite it not being formally supported, it works well Well, that's a wrench. Hmm
@drewejohnson I just tried to run the ARMI tests on MacOS and 18 of the 2064 tests failed: https://github.com/terrapower/armi/actions/runs/8898351718/job/24435316299#step:5:2441 Most of the errors were of the form: > No such...
> We have a lot of mac users here despite it not being formally supported, it works well @drewejohnson Just FYI, I just opened a PR to support Macs: https://github.com/terrapower/armi/pull/1713
This was about #1673
Too much time has passed, I will try to get to this PR again in August/September. I still think this is a good idea.