John Stilley

Results 306 comments of John Stilley

I like the idea! Do you have any guesses on what current tools adding a `.shape` would break? I'm just asking for documentation purposes. So we can build a LOE...

> The internal equilibrium capability has lots of fanciness... Heck, I could copy/paste all the code they need into their project, if they need more than the "new" DB3 can...

I like this. This is a fine idea to support. I like the functionality, it fits within our current design goals, and it seems like a reasonable feature to maintain...

@albeanth Okay, my read of the situation is this is a bug. Unless you disagree, I am assigning the bug to you, because it has the phrase `applyHot` in it....

I would be curious to know how this problem relates to this docstring: https://github.com/terrapower/armi/blob/bc556fc5ce3f0445a4b1e841f00b8bdc3888f5a3/armi/materials/material.py#L341-L348 This has been in our codebase for at least 3 years.

Oh, yeah, I much prefer deterministic code. The most obvious solution seems like output keys should be printed in alphabetical and numerical order. Off the top of my head, I...

I have opened a ticket for deterministic ordered in `yamlize`: https://github.com/SimplyKnownAsG/yamlize/issues/12 And I will probably do the work myself, I'm just not absolutely certain I see all the places changes...

Hey, @keckler, can you send me an example or two of this problem? You can do it via email, or whatever, so it doesn't have to be cleaned up for...

I have a unit test that demonstrates this bug: https://github.com/john-science/armi/commit/b075b5719cc0ef9d555e863fe3c8cbf1ed396a56 Essentially, the test always fails, but it wouldn't if we had deterministic ordering. In particular, the attributes of the given...

Okay, so this is kind of our problem. Essentially, Yamlize is really good about deterministically ordering elements before they get written out to the YAML file. But we go out...