John Stilley

Results 306 comments of John Stilley

Okay, I can only find the one feature left unsupported by blueprint files: `ThetaRZ` reactors. So, these two files: * `armi/tests/trz_geom.xml` * `armi/tests/ThRZGeom.xml` So, we need a blueprint/YAML format to...

I believe the YAML version of the ThetaRZ geom/xml file should look something like: https://github.com/terrapower/armi/blob/0c6d0ae3390d0248f4747125f4cdaaaae1d9db5d/armi/tests/Godiva-blueprints.yaml#L296-L334

This seems like something I could handle. And you're totally right, performance is my only real concern here.

I implemented a pure-Python solution for this. It's fine, but slow. I think the real solution might be we wait until NumPy makes the change and then just catch the...

@scottyak @jakehader Thanks for the library idea! I'll check it out. My primary concern is performance here, if it performs well against NumPy, than this is great. My second question,...

@scottyak Sure, go for it! If this is more of a drop-in than some giant replacement, this could be a huge win. My guess is that we would only need...

Okay, the version in `setup.py` has been bumped to 3.7+. And everyone seems okay with it.

There have been a couple of minor outages with coverals.io this week. I thought I was going to close this ticket AGAIN, but now I'm thinking maybe it's still relevant.

Okay, in the past 13 months, coveralls has been pretty stable. So I will close this ticket, and only reopen it if we have more issues.

@youngmit What is the status of this?