John Stilley

Results 306 comments of John Stilley

Okay, after more trial and error, I can't find a great solution to this problem. I tried to access the inner workings of our three YAML libraries, to fix the...

It's an interesting point. The major reason I discounted this idea to begin with is that several downstream projects (that import ARMI) don't want `PYTHONHASHSEED` to be set. For instance,...

@youngmit Could you assign this to me, please? Thanks!

Before I go about the business of refactoring our code to make the settings immutable, I have outlined below all the places in the ARMI framework we mutate settings. From...

> 4: Not even sure what we need this for. Very odd... 6 is doing something similar. I am suspicious of this pattern. **Fun Fact:** These two methods `setStateToDefault` are...

A note on progress. We are 75% of the way through making settings immutable. Much progress was made. The major thing left to do is remove the fact that someone...

In the past ~9 months, the changes we've made to making Settings more immutable have stabilized and become standard. They are not 100% immutable yet, sadly. As making that happen...

As a matter of "good design", I would also like to point out this code: https://github.com/terrapower/armi/blob/fd5d2dd31051206ce62696027f05a9304b499677/armi/reactor/blueprints/isotopicOptions.py#L514-L538 It seems a little inside-out that we have to make definitions here that relate...

My assumption is that this is the block of code we are talking about, and it looks like it already has the basics: https://github.com/terrapower/armi/blob/master/armi/bookkeeping/db/database3.py#L563 Though, as you say, we could...

@drewejohnson I like your `hostname` idea. That's an easy win. For the commit hash; my original concern was that when someone runs ARMI they might do so on their own...