Martin Herndl

Results 131 comments of Martin Herndl

weird, right now your pasted command is working fine for me. It was using Composer 2.3.9.

You can play around with different output stream redirections. `grep -v` also works quite well to remove single lines I heard.

👍 the last constant array performance issue I debugged also resulted from `TypeCombinator::reduceArrays()` IIRC. I remember trying out the same thing with simply returning the constant arrays and it was...

I'm interested for sure in that, but not only for the in_array impossible type check adaptions, but apparently trying to fix that lead me to problem b which lead to...

There's no way to describe that e.g. `array` has an **offset value type** of e.g. `0`, right? meaning that we have an int array but one of them is 0...

I had a similar idea that I was playing around with yesterday. If that works, it might solve many of the in_array problems. I'll keep looking a bit in that...

I'm getting closer. I found a thing that confuses me though: given the type `non-empty-array`, shouldn't `->hasOffsetValueType(new IntegerType())` answer that with `yes` instead of `maybe` because of the intersection of...

I seem to be down to one weird extra conditional needed only. and it is a bit related to the previous comment I guess. maybe I'll open a PR later...

jfyi the error here seems to be not related to traits, e.g. https://phpstan.org/r/8095872e-12f0-4fa6-861a-db78490f3bc2

@mad-briller just wanted to say thx for the link. It was interesting to listen to Jan explaining the Type system :) It almost hurt me a bit when he talked...