Martin Herndl

Results 139 comments of Martin Herndl

I did not read through all comments, but I think we need to be careful that this doesn't become another `in_array` in regard of impossiblechecktype adaptions needed. Preferably none should...

I'm looking forward to this feature too. I should be able to get rid of some local config entries most likely :)

> @herndlm after your recent changes on the mixed type I see new/no longer reported errors after rebase. > > would be great if I could get your opinion on...

Oh, nice! Looks like we could get rid then of almost all of the custom expression building in the phpstan-assert* extensions :)

I need to think more about this but the changes here did not activate the "is not covariant with tentative return type void of method", they were already there. The...

I'm not sure what to do with this one. It makes sense to me, but maybe I misunderstood what was going on. I'll give it a good old last force-push...

It's not for me to decide obviously but I like the new helper method. I'd make it private and use it internally wherever possible to simplify things. But better wait...

sorry to hijack this, I thought it's a good place for further getType / getNativeType questions. I noticed that `TypeSpecifier` mostly uses `getType()` which basically ignores the native type, right?...

This has such an impact although it was already implemented in create?

I'll take a look because I'm very nice (and like to debug those things) ;). but please don't expect too much and please be patient. Current state (after already removing...