Martin Herndl
Martin Herndl
> should be easy fix Waiting for your PR 😊
the performance problems should be fixed in phpstan for sure. this PR was meant to just clean up the stubs a bit further which is not really related and makes...
2. if you want to remove a node I think you have to do this via `leaveNode` instead, see https://github.com/nikic/PHP-Parser/blob/v4.13.2/lib/PhpParser/NodeVisitor.php#L45 3. sure, that's fine! feel free to keep it open,...
I briefly scrolled through it, yeah. Was looking fine to me. But please let's not argue over this, if it's too risky then it shall not be touched and over...
rebased on master and added the config change I had apparently lying around since May :D
I realized that what I pushed was not ready yet, now it is, including the help adaption.
but let me add a test case for that, sorry :) UPDATE: now I'm ok with it
@vitsadecky is it possible to provide a repository/project to reproduce? Although, I guess if Ondrej labelled it without further questions he might know exactly what the problem is :)
Jfyi I think we need to be careful to not introduce too many instanceof checks, see also https://phpstan.org/blog/why-is-instanceof-type-wrong-and-getting-deprecated :) But don't let this block you here, maybe for the next...