Martin Herndl

OK close, better than I thought. I guess I deleted too much and am loosing the benevolent template object..

Good question, I'm not sure if it should be tbh. If we explicitly want a union, shouldn't it be non-benevolent? 🤔 I guess what I'm saying is, are we expecting...

The main intention behind this is that I believe, and I think the linked issues confirm it, that union with a benevolent union should not suddenly get rid of the...

Added the test cases for union with `(int|string)` you requested, we get the following > When we add a `ConstantStringType` like `'1'`. `(int|string)` > When we add a `StringType`. `(int|string)`...

Ok, added your mentioned cases again, the result is a bit different, I got - `(1|2)|string` UPDATE: but `('1'|'2')|string` does result in `string`, not sure if I misunderstood that or...

@drupol are you referring to the bot message you got in your issue (which is unrelated to this PR) or https://github.com/phpstan/phpstan-src/actions/runs/3910108845? :)

> Sorry, here's the proper link: [phpstan/phpstan#7423](https://github.com/phpstan/phpstan/issues/7423) I also fixed it in my previous message. yeah and why do you mean this PR does not fix it? the bot message...

Did we come to a conclusion about this one? :) I rebased it on 1.10.x in the meantime. Thought the behavior change might be better there. In case it gets...

Going to rebase this one tomorrow morning. Is there anything else I can do here? This still makes sense to me :)

Nice, perfect timing! I was just looking for something like that.