Martin Herndl comments

Results 139 comments of


Martin Herndl

Support string assertions resulting in non-empty-string

I want to check if I can make it report if those functions are called more than once with the same args

Support string assertions resulting in non-empty-string

Now it works as I imagined :) I'm gonna add the same double-check-report adaption to phpstan-src with `str_contains` if possible.

Support string assertions resulting in non-empty-string

jfyi in case it was missed - I think this one should be good

Support for assertions resulting in non-empty string

This should be possible to do now thx to https://github.com/phpstan/phpstan-src/pull/1254 which also solved a couple of other problems. See https://github.com/phpstan/phpstan-src/pull/1068 where something similar was done in phpstan itself. I think...

False positive: Call to inArray() with different object instances will always evaluate to true

Interesting, I just tried to add a regression test for this. The current state is - the [original snippet](https://github.com/phpstan/phpstan-webmozart-assert/issues/142#issue-1276742494) is *still* reported and therefore not fixed - the [snippet from...

False positive: Call to inArray() with different object instances will always evaluate to true

ah right, I was just super confused because I could *not* reproduce it in a phpstan snippet. actually it never reported even when it definitely should. that explains it all...

Treat assertNotWPError() and assertWPError() as type-narrowing functions

I'm not an expert and never used those WP test helpers. But it looks they are at least not part of the official WP release. Are they WP internal? Does...

Treat assertNotWPError() and assertWPError() as type-narrowing functions

@johnbillion are you still interested in this? If you could just provide me with an easy to work on example I can implement this next Wednesday, should not be hard....

Add type checking for hook callbacks in `add_action` and `add_filter`

ok then, I'd say go for it! :)

Add type checking for hook callbacks in `add_action` and `add_filter`

there are still the \FQCN problems there was another issue about. I had an easy solution in mind, but I think you didn't like it because it involved a phpstan...