Martin Herndl
Martin Herndl
Interesting, fyi @matthiasnoback also recently started a discussion related to RuleTestCase: https://github.com/phpstan/phpstan/discussions/8006
~~btw were all functions moved to `Utils`? If so, should this be mentioned too maybe? I could just add it.~~ never mind, apparently they weren't
> The docs look good, could you add some test cases using objects, so we cover it in our unit tests? sure, adapted
@BackEndTea in case you didn't see it: should be adapted. In case you're just busy: no worries, this is not important 😊
Yeah exactly, that would fix most of the problems, if not all, here. That's why I was so looking forward to HasOffsetValueType. Until I realised it needs a constant key...
Can you try to extract the core problem with php functions on phpstan.org? Maybe it is a problem in phpstan itself we can improve
jfyi I took a look and wanted to add that the coverage metric is a bit misleading here. E.g. `DynamicReturnTypeExtensionTest` has the dataprovider `dataFileAsserts` that gathers assert types of many...
fyi this was also briefly discussed in https://github.com/phpstan/phpstan/discussions/8238 and apparently it is a known problem, the code coverage via dataproviders is currently just wrong. I don't have any fix for...
But I was thinking into looking this on phstan side a bit more. I'll let you know if I find out more
This was completed, wasn't it? 🎉