Martin Herndl

Results 139 comments of Martin Herndl

should be fixable with an entry to https://github.com/phpstan/phpstan-src/blob/1.8.x/resources/functionMap_php80delta.php in case you're interested in adapting this yourself :) one of the last similar changes there was e.g. https://github.com/phpstan/phpstan-src/commit/3d307588be75d835ad2ecdcb2ebf056baaa1ae7f

Good question, I kind of forgot that 😅 Normally tests are added for those rules that were wrongfully showing errors. In this case it would be `CallToFunctionParametersRuleTest`. Maybe check the...

Sounds like a simple thing to implement that adds value! I can work on it. That would be just a new rule or does the static reflection label imply more...

If you have it working already, then you can go ahead as well :) I would have most likely done it in a similar way. Maybe the loop logic can...

Maybe something similar as https://github.com/szepeviktor/phpstan-wordpress/issues/99#issuecomment-1112832557 Not sure if it explains the errors here though. Also: looks like you referenced mission impossible there too haha

Or could it be the discovering symbols related part from what John linked? Feels related to what Viktor mentioned with autoloading too. Using a debugger or messing around with phpstan-src...

The phpstan release is most likely not necessary. After it was merged you should the able to require the _next_ patch version and it will pull the current dev branch...

ah right, I introduced usage of the old method again in the meantime in `HasOffsetValueType`, sorry 😊

oh, this is more interesting after all.. here are 2 failures - ~~https://github.com/phpstan/phpstan-src/blob/1.8.9/tests/PHPStan/Analyser/data/bug-3875.php#L13 is `mixed` instead of `'foo'` because `$queue` becomes `NeverType` in the second iteration of the loop after...

Yes, because those return the first or last element. I mixed this up recently as well :)