Robert Findley

Results 271 comments of Robert Findley

We have unskipped all flaky regtests.

`[email protected]` significantly reduces gopls' memory usage, up to an order of magnitude on larger repositories. Closing this as resolved. Please open a new issue if you are still encountering memory...

I just implemented something similar to this in https://go.dev/cl/531417. Notes on how to implement this: - Thread through directory filters to where we do 'metadata'-based unimported completion - [here](https://cs.opensource.google/go/x/tools/+/master:gopls/internal/lsp/source/completion/completion.go;l=1745;drc=7f23bc81dc216f83d56b5256abc053109bf5c58b), for...

Update after a year: that long road has been walked. [email protected] redesigned the core of gopls to use drastically less memory. I'd be curious if this helped the situation with...

I have been thinking about this recently. I think we should have two modes for semantic tokens. - "syntax": syntax only, no type-checking; maybe even just tokenization - "types": the...

FWIW, the diagnostic tags added in https://go.dev/cl/415499 _do_ work in neovim, and I've had the opposite reaction: I keep getting confused because my code doesn't compile even though there are...

Thanks for this feature request. I agree this is a useful refactoring. Right now we're focused on scalability and workspace setup, but we hope to revisit refactoring features later this...

Hi, sorry for the slow response on this issue. We discussed this in our triage meeting, and the problem is tricky to get right. In some contexts (e.g. a binary...

@hyangah sounds great to me. Will we add the vanity module path, or simply use the github path? I think per discussion with @rsc either would be fine.