Robert Findley

Results 271 comments of Robert Findley

@vikblom indeed, struct fields *do* work. I think that decreases the utility of this issue significantly; jumping to the type definition of call expressions can be achieved by jumping on...

@vikblom sure, I think you could pick this up. Seems straightforward and useful.

Hi @vikblom, sorry for the slow response. The package `foo_test` will essentially always import package `foo`, and when it does so, it will import the test variant of foo (what...

> Therefore, it would be an error for a type to exist in both foo_test and foo.test I'm sorry, but this was a total hallucination or bad miscommunication on my...

@vikblom I think we want to avoid new flags whenever possible. The way the functionality is implemented in your CL is such that existing use-cases should continue to function as...

To summarize, here are reasons to do this: 1. Persistent links for interacting with gopls across sessions. 2. Earlier error handling if the web server can't be started. 3. Improved...

@matloob @samthanawalla @adonovan Any particular reason why *only on openbsd* we'd be seeing these cleanup failures? Was there any recent change to the go command on openbsd? I don't think...

Closing as working as intended.

@hyangah I put this in the v0.42 milestone, but the goal should just be to land this by mid-august, when we plan the [email protected] release. Please re-milestone as appropriate.

Decision: VS Code is going to set GOTOOLCHAIN=auto so that the toolchain upgrades work as expected.