findleyr

The following flake occured on https://go.dev/cl/422135: https://storage.googleapis.com/go-build-log/a34a97d8/freebsd-amd64-12_3_7f502470.log `greplogs` does not turn up any recent flakes on the builders, but this one flake suggests that there may be a race to...

x/tools/gopls: release version v0.9.2

4

This issue tracks progress toward releasing [email protected] - [x] merge master into gopls-release-branch.0.9 - [x] update hard-coded version - [x] update go.mod/go.sum (remove x/tools replace, update x/tools version) - [x]...

x/tools/gopls: unskip all previously flaky regtests

4

This is a follow up to https://go.dev/issue/53781, a deterministic panic that made it into [email protected] in part because a flaky regression test had been skipped, and not un-skipped when the...

x/tools/gopls: automatically include open packages in the workspace

1

Noticed indirectly via #53933: when packages are outside of the workspace, autocompletion stops working because it operates on packages in "TypeCheckWorkspace" mode, which means it does have function bodies for...

Add a tutorial document (and maybe screencast) for using `go.work` files with VS Code. CC @hyangah

Hi! I noticed the following failure in gopls' govim CI: ``` FAIL: TestScripts/scenario_diagnostic_assertions/multiple_files_compile_errors_in_one (59.93s) testscript.go:397: # Verify that we receive initial diagnostics for files that have compile errors # but...

cmd/govim: track go.mod files

7

Gopls supports some features for go.mod files that can work "out of the box" except that they are not tracked in govim -- see https://golang.org/issue/31999. In particular, I was trying...

x/tools/gopls: friction working with internal/lsp/tests

4

This issue catalogs friction experienced with the LSP "marker tests" in internal/lsp/testdata (run by internal/lsp/tests). These tests have long been tricky to work with, and recently have caused a significant...

go/parser: composite lit fields resolve incorrectly

2

Resolving struct fields is a known limitation of go/parser object resolution. However, there is an additional bug that composite lit fields may be incorrectly resolved to unrelated declarations in the...

I added `experimentalWatchedFileDelay` for LSP clients that don't buffer file change notifications. In retrospect, I think this was a mistake: - Clients have more knowledge of user intent, and so...