Robert Findley
Robert Findley
Two observations: 1. We're not checking the error from `Kill`. If killing failed, I don't think we can expect Wait to return. 2. Discussion at https://groups.google.com/g/golang-nuts/c/pUaEjqd5wo8
Interesting, I was debugging this in https://go.dev/cl/424075. On windows, our call to Process.Kill() is failing with "invalid argument": https://storage.googleapis.com/go-build-log/e2f60200/windows-386-2008_71ad7007.log A bit of googling suggests that this is because we can't...
After reading the source a bit more: this is EINVAL, which appears to mean that the Process.wait() has exited and the handle released, so this is a race, although it...
A hit! https://build.golang.org/log/4eea0e5bfe425fcd097a49fcb92fd015fa88f383
``` 13032 12910 (compile) 9802 13032 go list -modfile=/tmp/workdir/tmp/go.8f5d4cc245da9790bda529e64ae3e7 ``` Looks like the hanging go command is in the middle of a compile. Wish we had the full subprocesss command...
Aha, thanks (excuse my ps noobness). Note that we instrumented this panic in two places: once before `Kill()` and once after. This is _before_, so I don't think it falsifies...
`greplogs --dashboard -md -l -e 'HANGING GO' --since=2022-09-15` [2022-09-17T02:56:51-4d18923-cc1b20e/netbsd-amd64-9_0](https://build.golang.org/log/333cfe1792860f9ae99158d4b91be4de74ee565b) [2022-09-16T17:59:31-a61f20e-a84f46a/netbsd-amd64-9_0](https://build.golang.org/log/caf074922535c82086b3055373afed4eb7c852d6) [2022-09-16T16:33:11-a61f20e-8451529/netbsd-386-9_0](https://build.golang.org/log/df54908eba0ab6e17498c82572922785dd399591) [2022-09-16T14:49:13-a61f20e-b35b4a3/netbsd-amd64-9_0](https://build.golang.org/log/4eea0e5bfe425fcd097a49fcb92fd015fa88f383) Still only netbsd. Posting the `greplogs` query here for future reference.
@adonovan but in this case the panic indicates that we waited up to 10 seconds *after* that kill. The error from Kill is merely logged. Per @bcmills comment on the...
> There is one where an additional t.Run is used as parentheses to say when a group of parallel tests finishes: Thanks for pointing that out. In the current implementation,...
Hi @rneatherway, sorry for the slow response. Sure this is a good starter project, and a good way to get started would be to solve the problem outside of gopls...