Robert Findley

Woah. I've never seen anything like that before. I'm not sure what mechanism would even cause a loop like that: perhaps some interaction with auto-saving in vs code. Needless to...

BTW, when I initially read the issue, I thought you said "It happens since 0.8.4" (which is a recent gopls version), but you said It happens since 1.18.4, which is...

Could you also please share your vscode settings.json, and whether or not you have any other extensions installed that may format Go files?

Putting this in the v0.10.0 milestone as given more information we'd like to fix this bug expediently. However, since we can't repro it will be very hard for us to...

If the issue is resolved by a vscode update, that points to bad interaction of gopls edits with other vs code edits. Is it reliably reproducible with the older version...

Thanks for confirming. I think this is probably a VS Code issue, as AFAIK there's nothing in gopls that would lead to this behavior. Please reopen if this is reproducible...

While working on an unrelated test, I realized that the heuristic is not quite right: we should not "include all packages containing open files" in the workspace, but rather "ensure...

@ymolists can you clarify why you think this is related to storage.json. Specifically, I see the locking in your `code-insiders.verbose.log`, but in what way is it abnormal? Does it only...

@ymolists sorry I meant that I looked at your `code-insiders.verbose.log`, and see the locking on `storage.json`, but I don't understand why we should conclude that this is a problem.

Thanks for the report. We should fix this.