Robert Findley

Results 271 comments of Robert Findley

I think we've talked about this in the past; it would require making 'ignore' special, but that seems fine to me. We have a long-standing issue to improve handling of...

This is perhaps a medium-sized project, but would resolve some of the pain points around build tags. While it requires an understanding of the complicated way that gopls resolves packages,...

@wonderfate I replied on that issue, which I had not seen. I don't see a bug there: it looks like it is working as intended. Meanwhile, let's please keep discussion...

@wonderfate this issue is currently scheduled for the next gopls release, in September. There's always a chance it may miss that milestone, but barring some unforeseen technical obstacle it should...

Thank you for this issue, and apologies for the slow response (for some reason this issue wasn't put into the Unreleased milestone until I updated the issue title, so it...

@mknyszek thanks for reporting. Hmm. I don't think that flake is actually related to TestCreateDependency: it is simply an error deleting the test files during cleanup. greplogs also turned up...

Thanks @bcmills. Yes, that looks related, so let's not file new issues. There is a fair bit of activity on #36435 that may be related.

That gopls uses a lot of memory is a known (and difficult) problem. See for example #47855. However, 5gb is a lot, and we should check whether that makes sense...

Thanks. I expect you'll see it stay in the the ~3gb range after [email protected] is released. I'll take a look at the heap dump you've provided to see if I...

Putting this in the next milestone for additional triage.