Robert Findley

Results 271 comments of Robert Findley

@adonovan and I just discussed where to go with this next, and there are a few major problems we'd like to solve: 1. the global namespace of marker tests: adding...

Confusingly, there was a second bug (root caused in https://go.dev/cl/461418) which I believe was causing *the same symptom*, albeit with less frequency and only on s390x, which must have low...

It looks like the issue may be related to file watching: gopls doesn't ask VS Code to watch the vendor directory. (I discovered this after implementing proper support for glob...

Since this failure, I've completely rewritten definition/hover/type checking. So I'm not entirely sure what this was, but absent another failure I think we should assume this is unactionable.

@hyangah do we need to register a new selection range provider? It may be that this needs a vscode-go change as well.

Thanks for the questions, @ShoshinNikita. Quick thoughts below. 1. I also don't know where the best location for the link is, and want to hear from others. 2. Yes, we...

With CL 419988, gopls benchmarks are now proper benchmarks, and can be run without any additional flags. For example: ``` > cd gopls/internal/regtest/bench > go test -bench=DidChange checking out https://go.googlesource.com/tools@gopls/v0.9.0...

Yes, that's correct. Can we use @master for benchmarks, actually? There is an additional fix that also isn't in v0.9.2 (which will be released today or tomorrow.

@dr2chase thanks! Thinking about this use-case, I just added a new flag in [CL 422908](https://go.dev/CL/422908). The `-gopls_commit` flag can be given an arbitrary commitish, and the test runner will build...

Following up on a discussion with @dle8, the easiest way to run benchmarks at the experiment (but gopls at baseline) is as follows. Assume `$BASELINE` and `$EXPERIMENT` are the directories...