fanquake
fanquake
At first glance, I'm not sure why we'd want to start skipping commits, in a CI job, where the entire purpose is to test all commits.
> While this approach introduces some duplication at present, it will ultimately enable us to consolidate how the IWYU tool is executed, allowing for a choice between using the iwyu_tool.py...
> may be good to fix the aarch64 ci. How would you fix it, given IWYU is giving different recommendations, based on the architecture?
Is this only an issue with master (regression) or also a problem if you run 25.0 or 25.1rc1?
I haven't looked extensively, but there are packagers that point directly to these files. i.e https://github.com/NixOS/nixpkgs/blob/9771deb49b9b8b0b83615d11c070b071b18db2ab/pkgs/applications/blockchains/bitcoin/default.nix#L31 or https://github.com/void-linux/void-packages/blob/b931884fcc6114400b4cad338a286478b2c731e9/srcpkgs/bitcoin/template#L16.
> Avoid having many static libraries Can you expand the motivation.
@theuni could you circle back here?
> Are you still working on this?
Closing for now, due to no/lack of followup. Please leave a comment, if you want this reopened.
https://cirrus-ci.com/task/5580834063777792?logs=ci#L1854: ```bash test 2024-12-11T17:44:45.280000Z TestFramework (ERROR): Unexpected exception caught during testing Traceback (most recent call last): File "/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 132, in main self.run_test() File "/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/wallet_migration.py", line 1095, in run_test self.test_migrate_simple_watch_only()...