fanquake
fanquake
Guix Build: ```bash 9607cec72e511df72d1d07ef850015172d6c2707604f46694c019cd37903c65b guix-build-74dfa4155037/output/aarch64-linux-gnu/SHA256SUMS.part 30916e57efaa2bfd4265d840cde7049c863c4d35cec9d5e70681e7bc428e2d14 guix-build-74dfa4155037/output/aarch64-linux-gnu/bitcoin-74dfa4155037-aarch64-linux-gnu-debug.tar.gz c462783e946c5e3e61a6a4ab4be1b8ddb6db9be07194d3241b43a8cc4cbe81f7 guix-build-74dfa4155037/output/aarch64-linux-gnu/bitcoin-74dfa4155037-aarch64-linux-gnu.tar.gz 23b60343ce14152fca5f934a3c57d130d665bd5298028f18c2118f646d53841d guix-build-74dfa4155037/output/arm-linux-gnueabihf/SHA256SUMS.part 81289e78cd5930543c7dfb529ff6a439606d9d2836b0c5664f6bb5b22acf8bb9 guix-build-74dfa4155037/output/arm-linux-gnueabihf/bitcoin-74dfa4155037-arm-linux-gnueabihf-debug.tar.gz c7bebaa586850cd715fdf990dae5bdc60272f4aaa8b528254d2c4051710b0082 guix-build-74dfa4155037/output/arm-linux-gnueabihf/bitcoin-74dfa4155037-arm-linux-gnueabihf.tar.gz df16bd44d340f4a3571045d5983fb80cc278f671cea7cf5a03ddf6fd7316ff3a guix-build-74dfa4155037/output/arm64-apple-darwin/SHA256SUMS.part e283c1bb16050f583359172bf239965c0a584d804ac3fac7bf847ab8d604261d guix-build-74dfa4155037/output/arm64-apple-darwin/bitcoin-74dfa4155037-arm64-apple-darwin-codesigning.tar.gz bfba93334e7ee53b7cc02f589f24d1b2165494c5a90eeba39b00d8ea70b6fb05 guix-build-74dfa4155037/output/arm64-apple-darwin/bitcoin-74dfa4155037-arm64-apple-darwin-unsigned.tar.gz da1e5edd2cb9ae303b834990ac1fa2ebacb76baf8f0dac514ba1b1fc90711160 guix-build-74dfa4155037/output/arm64-apple-darwin/bitcoin-74dfa4155037-arm64-apple-darwin-unsigned.zip 6ec26a5e72061b1255f50fbe65d84f1a5c21fe8db7e754c62a279d5fa17961f6 guix-build-74dfa4155037/output/dist-archive/bitcoin-74dfa4155037.tar.gz 6c31f2e067a67646ade357afa58baa2ec213064bd4a9e6735c9f77f012a7e916 guix-build-74dfa4155037/output/powerpc64-linux-gnu/SHA256SUMS.part 9e0b5d5784dc1a5a8b0226d4140edd1259e267e31293e7316ba13aa2f754e142 guix-build-74dfa4155037/output/powerpc64-linux-gnu/bitcoin-74dfa4155037-powerpc64-linux-gnu-debug.tar.gz 51761c0923ca13bee3710ed612e6fb5fedb5b000c183c618c3580085746e8501...
Guix Build: ```bash 8ee8f51264bd5f28d838207486f83db69a1dd4d00eeda009f35ef9ebff794d0f guix-build-4f56c9145a60/output/aarch64-linux-gnu/SHA256SUMS.part aaf5a45736f062df340bbd434295a087f90897401a8d9e1489f5ad56c4a82fab guix-build-4f56c9145a60/output/aarch64-linux-gnu/bitcoin-4f56c9145a60-aarch64-linux-gnu-debug.tar.gz d6b4a08a7e9dad84dcfdc504896cf0b13a4c2c416ef8608903cd542297936f74 guix-build-4f56c9145a60/output/aarch64-linux-gnu/bitcoin-4f56c9145a60-aarch64-linux-gnu.tar.gz c236ea00cde9621315a84153c0e672c8f9299d93efe379ff82188e2e018167e3 guix-build-4f56c9145a60/output/arm-linux-gnueabihf/SHA256SUMS.part 719c221a599298d5795ce82c0dc051ea512e2f17d6c918fc9e5c938f5aaae83c guix-build-4f56c9145a60/output/arm-linux-gnueabihf/bitcoin-4f56c9145a60-arm-linux-gnueabihf-debug.tar.gz 0870aa09463c757f12fd27e29b55fa725a7fc62f5bc3dd02a41a99968a8faa7e guix-build-4f56c9145a60/output/arm-linux-gnueabihf/bitcoin-4f56c9145a60-arm-linux-gnueabihf.tar.gz 222a1bee4640df2263e92fd6467f622fbdd6e15fe9d377f10916f2832ae9c0f5 guix-build-4f56c9145a60/output/arm64-apple-darwin/SHA256SUMS.part 1f669eb0faddbfeb0a2c23514e0e4653cac965e086e92076b1d8e48702268417 guix-build-4f56c9145a60/output/arm64-apple-darwin/bitcoin-4f56c9145a60-arm64-apple-darwin-codesigning.tar.gz 58978c20a84de0676ed9b1e087fb6c3a9e28ab3ad75ac269dd13dac83cebe4f5 guix-build-4f56c9145a60/output/arm64-apple-darwin/bitcoin-4f56c9145a60-arm64-apple-darwin-unsigned.tar.gz 345c1b41712de6eea8df60be38dac7c9207ac887e824f8a0802c1acc59d31493 guix-build-4f56c9145a60/output/arm64-apple-darwin/bitcoin-4f56c9145a60-arm64-apple-darwin-unsigned.zip c3dbbe57d48d93360c78b3cb67593e3c5e8ddca7db407f1c065689db5ddcc3ec guix-build-4f56c9145a60/output/dist-archive/bitcoin-4f56c9145a60.tar.gz 858eab2b79b7e68d6b94a13cf1273aab3932357b2430f9aca53c096d31520471 guix-build-4f56c9145a60/output/powerpc64-linux-gnu/SHA256SUMS.part c3269ae4d281d368de79de007893addeee8f3415e5d2e745da8522eab28c1df4 guix-build-4f56c9145a60/output/powerpc64-linux-gnu/bitcoin-4f56c9145a60-powerpc64-linux-gnu-debug.tar.gz 52f6866dfd6ad777f8301d9d81e24571c35df3be6836fe5d05eaf07f10902cef...
If we are going to change this, I think you should just change it to C++20.
We aren't trying to retain C++11 compatibility?
You could also update the CMake minimum required to `3.22` (just matching the Core minimum required).
We don't use the CMakeFiles from this repo; we just compile the objects we want directly, using our own options.
> This change only partially resolves https://github.com/bitcoin/bitcoin/issues/32391 What is left unsolved after this PR?
> But, it probably would still make sense to close https://github.com/bitcoin/bitcoin/issues/32391. Yea, on our side, this should be enough to close #32391.
Guix Build: ```bash d9e24e61f22de8b9d83cbbec4830bdb9192ab55ac90aba125a53ec9fba719d67 guix-build-6b4bcc162345/output/aarch64-linux-gnu/SHA256SUMS.part 9780961f5ce0c23db0f6ec4b9930728344a3cb4706e4a36dff2364f12905acf8 guix-build-6b4bcc162345/output/aarch64-linux-gnu/bitcoin-6b4bcc162345-aarch64-linux-gnu-debug.tar.gz 2f281a8e266bab0631e40a738db21a4f4865aa2e91e9dfadc2d208b05d5a2f8b guix-build-6b4bcc162345/output/aarch64-linux-gnu/bitcoin-6b4bcc162345-aarch64-linux-gnu.tar.gz 1639f2ab6e353d5aa01805ea29ab37f8d8e428db33eaf9a6ab444e80c24095ae guix-build-6b4bcc162345/output/arm-linux-gnueabihf/SHA256SUMS.part fcb900592021d4e8f607a31d8267e36761fdc0036640d9c3086faadadedd99af guix-build-6b4bcc162345/output/arm-linux-gnueabihf/bitcoin-6b4bcc162345-arm-linux-gnueabihf-debug.tar.gz b67ca8083748df84cdaacbbcd509543465ff7ad7ad447dada641ff20223900a8 guix-build-6b4bcc162345/output/arm-linux-gnueabihf/bitcoin-6b4bcc162345-arm-linux-gnueabihf.tar.gz 03aebe7ee1be27aa60e36d3fe3628019d6e8d82051bc4b00ef88dd45c2cc763c guix-build-6b4bcc162345/output/arm64-apple-darwin/SHA256SUMS.part a3912fe813360058218f5210bc2ff3e1bfd02ba962213d9758428fb19529a81d guix-build-6b4bcc162345/output/arm64-apple-darwin/bitcoin-6b4bcc162345-arm64-apple-darwin-codesigning.tar.gz 973347c1384df645a8a38d3c39bcb956b041905152da95811e77db1eb43bc296 guix-build-6b4bcc162345/output/arm64-apple-darwin/bitcoin-6b4bcc162345-arm64-apple-darwin-unsigned.tar.gz db1345fd1030ddd7aab01a5a1130d6feb9532d93175a731814ec074b417e739e guix-build-6b4bcc162345/output/arm64-apple-darwin/bitcoin-6b4bcc162345-arm64-apple-darwin-unsigned.zip 210da4f7a96e74cfb9350549281b04106481a540b0f8b86d6a303c5bfa8ed3e3 guix-build-6b4bcc162345/output/dist-archive/bitcoin-6b4bcc162345.tar.gz 70160c2387635f3175c1e799ade355c4c9bd6eed3f7911a99385c737ef69d2ab guix-build-6b4bcc162345/output/powerpc64-linux-gnu/SHA256SUMS.part e3e2287a4be6b061ed5da3086f57e28c38284493811fc028f14353a04a34a5e8 guix-build-6b4bcc162345/output/powerpc64-linux-gnu/bitcoin-6b4bcc162345-powerpc64-linux-gnu-debug.tar.gz fcb82c445a113c4b7214f241d927155f4af648b859083a3df71855ff1b1ff569...
Concept ACK