fanquake

Results 918 comments of fanquake

Opened #30823 to add the explicit permissions usage. We can also use that PR to try and solve this issue, if wanted.

> I can confirm that the problem is caused by different umask values for the Linux users running the ./contrib/guix/guix-build script`. > We are already using a tool-level mitigation (for...

> reproduded the warning first, it doesn't appear anymore afer the change. Can you add any relevant output to the PR description.

> And then uses these ... in CI. I'm not sure about doing this. At least, not if it's going to use the same presets as the "general" dev presets....

> From https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html: > CMakePresets.json and CMakeUserPresets.json live in the project's root directory. Ok? We can put files where ever we want and just include them. i.e: ```json "include": [...

> Also, it allows to evaluate the codegen, which could be substantially better than msvc, or detect more msvc bugs. Does it? My read of the docs was that clang...

> < to be added > It'd be good if this could actually be filled in, so it's clear what the goals are / what's trying to be acheived here.

```bash test_bitcoin.vcxproj -> D:\a\bitcoin\bitcoin\build\bin\Release\test_bitcoin.exe lld-link : warning : found both wWinMain and WinMain; using latter [D:\a\bitcoin\bitcoin\build\src\qt\bitcoin-qt.vcxproj] lld-link : error : undefined symbol: __declspec(dllimport) PathRemoveFileSpecW [D:\a\bitcoin\bitcoin\build\src\qt\bitcoin-qt.vcxproj] >>> referenced by bitcoinqt.lib(guiutil.obj):(bool __cdecl...

Reading the description, I'm still not really clear on the goals here. It seems like this is just adding even more ways to compile for Windows, which we have to...

> prevents users from achieving optimal performance, Clang on Windows produces better performing binaries than MSVC?