fanquake

Results 961 comments of fanquake

> could you share the build/test/config.ini file? ```bash # Copyright (c) 2013-2016 The Bitcoin Core developers # Distributed under the MIT software license, see the accompanying # file COPYING or...

Not super pressing. I've been looking at ways we could build sqlite with CMake, given that will be one of the last Autotools holdouts. Some builders for the amalgamation exist,...

Looks like as of `3.48.0` (current release is `3.47.0`), SQLite is going to migrate it's build system from Autotools to [autosetup](https://msteveb.github.io/autosetup/): https://sqlite.org/src/timeline?r=autosetup. See also: https://sqlite.org/forum/forumpost/b7e2d83c0bcfae1e.

Updated the issue, now that Clang 19 is available: https://github.com/llvm/llvm-project/releases/tag/llvmorg-19.1.0.

Looks like this is working: https://cirrus-ci.com/task/5848920612405248?logs=ci#L2234 ```bash [14:18:46.371] 126/135 Test #130: spend_tests .......................... Passed 19.83 sec [14:19:14.504] 127/135 Test #110: txvalidationcache_tests .............. Passed 122.32 sec [14:19:15.437] 128/135 Test #8: bench_sanity_check_high_priority...

> will work. What do you mean by "work" here? This PR is just explicitly turning on one option in the compiler. > Shouldn't binutils ... also be CET-enabled? What...

> Configured with --enable-cet option. Similar to glibc, I'm pretty sure this autodetected for some time, but has has been the default behaviour for at least the last ~5 years;...

> the statement from the PR description: > is not accurate. That text is from the GCC documentation, and in this context, of, the compiler being configured for CET, after...

Guix Build: ```bash 94142f4399e6b57ae5d95364685cf545a20e1974eb3e6061e62b77af57e59a6b guix-build-89bf11b80725/output/aarch64-linux-gnu/SHA256SUMS.part 1bbbbc9c2818eb6c87a7d7164afc61eee299d8417d986832eb0d503484994f4b guix-build-89bf11b80725/output/aarch64-linux-gnu/bitcoin-89bf11b80725-aarch64-linux-gnu-debug.tar.gz 0601f57454694181473f03bc8ff6c6f23f6ff50f38190a9ff42bd351ff739460 guix-build-89bf11b80725/output/aarch64-linux-gnu/bitcoin-89bf11b80725-aarch64-linux-gnu.tar.gz 10ce23a32f6a21e4dd37cf770fdb20fd7e839b93093e53e54daa081e17f48a68 guix-build-89bf11b80725/output/arm-linux-gnueabihf/SHA256SUMS.part d61682531134d253d6d6e60a2ede9aca4dd1fcbbfc5c5fe5164ccd5c22db13ea guix-build-89bf11b80725/output/arm-linux-gnueabihf/bitcoin-89bf11b80725-arm-linux-gnueabihf-debug.tar.gz 1c7ecbe79cd08a5627c6365a40911df248b03a1c54e08657dc5cf047f8c76a25 guix-build-89bf11b80725/output/arm-linux-gnueabihf/bitcoin-89bf11b80725-arm-linux-gnueabihf.tar.gz b03639a4c3ee52797832da2b4013f2bb5264bf27c4f3bd70b08fc83f4167520f guix-build-89bf11b80725/output/arm64-apple-darwin/SHA256SUMS.part e43604c72c6611386c19eb4a2bde70813938a509ccc94c040725cd93797b9e3d guix-build-89bf11b80725/output/arm64-apple-darwin/bitcoin-89bf11b80725-arm64-apple-darwin-unsigned.tar.gz e640e9da6b4c1fdf19216e6f3a051b03de7cc9800e08ea80452db964177dc59a guix-build-89bf11b80725/output/arm64-apple-darwin/bitcoin-89bf11b80725-arm64-apple-darwin-unsigned.zip 08fb35f409538d588f1e68fe33a6421c65d39ebd0072ec648ebfa0a831dbfc11 guix-build-89bf11b80725/output/arm64-apple-darwin/bitcoin-89bf11b80725-arm64-apple-darwin.tar.gz 18bd25fb50f2143285102c8e7bcb158da066b634791fcb4cbb4abef4bdaed592 guix-build-89bf11b80725/output/dist-archive/bitcoin-89bf11b80725.tar.gz 432282fa224f441e681bc8f9f8c8d6d7c03f822a4ff11bf5d5d9b8e91b75f4dd guix-build-89bf11b80725/output/powerpc64-linux-gnu/SHA256SUMS.part fad4bef69045be2b8c976d4762143bbf8473276368dcc73109226b6e44cea76a guix-build-89bf11b80725/output/powerpc64-linux-gnu/bitcoin-89bf11b80725-powerpc64-linux-gnu-debug.tar.gz 29a3068abdfb0a6ce6d81c8fef5fc175f7949076dade3edd0e5577b798e7f326...

> with use of the subprocess library soon Note that `subprocess.h` is also using `wstring_convert`: https://github.com/bitcoin/bitcoin/blob/d62c2d82e14d27307d8790fd9d921b740b784668/src/util/subprocess.h#L1071.