fanquake

Put this on the `v30.0` milestone.

What is the status of this? Are you investigating the performance regressions?

Note that this will also appear broken in the summary: ```bash cmake -B build -DCMAKE_BUILD_TYPE=Debug Preprocessor defined macros ........... RPC_DOC_CHECK ABORT_ON_FAILED_ASSUME $ ```

`ENABLE_HARDENING` and the `hardening_interface` have been removed.

Seems like newer Clang 19 has improved this check, and throws out more (historical) instances to change. i.e: ```bash bitcoin/src/torcontrol.cpp:359:27: error: use starts_with instead of compare() == 0 [modernize-use-starts-ends-with,-warnings-as-errors] 359...

@willcl-ark Is this still the case?

Can probably squash, given the single line changed in the first commit, is then deleted/moved in the second commit.

This needs benchmarking on the systems used by devs (i.e Linux, and ideally those that previously reported issues), to ensure that we don't just have the same problem of Linux...

> I've put the before/after measurements in the commit messages, I'd prefer them separate You can put that in the PR description, that will be included in the merge.

```bash Configure summary ================= Executables: bitcoind ............................ ON bitcoin-node (multiprocess) ......... OFF bitcoin-qt (GUI) .................... ON bitcoin-gui (GUI, multiprocess) ..... OFF bitcoin-cli ......................... ON bitcoin-tx .......................... ON bitcoin-util ........................ ON...