fanquake
fanquake
```bash /home/runner/work/_temp/src/wallet/spend.cpp:474:12: error: calling function 'AvailableCoins' requires holding mutex 'wallet.cs_wallet' exclusively [-Werror,-Wthread-safety-analysis] 474 | return AvailableCoins(wallet, coinControl, /*feerate=*/ std::nullopt, params); | ^ 1 error generated. ```
@davidgumberg fyi you've ack'd the previous commit hash here.
lgtm locally (on aarch64). There haven't been many changes since rc3, but do you want to wait for final, (which should be on the 3rd)?
Given that final has been pushed back a bit, also happy to put this in at `rc4`, and bump it again later (if needed).
19.1.0 is now available: https://github.com/llvm/llvm-project/releases/tag/llvmorg-19.1.0.
I wonder if it was an intermittent `wine` related issue, but the output was missing. Similar to something like: https://cirrus-ci.com/task/6309656165875712.
Any chance this is now causing #30878? If so, would be good to fix before this is backported.
Not sure what to do here. Are there steps for debugging? @hebasto given this is Qt on Windows.
Is there anything for us to do here? Anything to be fixed? Should it just be closed? @hebasto.
> This issue boils down to two following calls: At a minimum I think we should start explicitly specifying [`NO_SOURCE_PERMISSIONS`](https://cmake.org/cmake/help/latest/command/configure_file.html#options) or [`USE_SOURCE_PERMISSIONS`](https://cmake.org/cmake/help/latest/command/configure_file.html#options) (the default behaviour) everywhere that we call [`configure_file()`](https://cmake.org/cmake/help/latest/command/configure_file.html),...