fanquake
fanquake
> Based on the Python package, can we (to some extent) automatically generate these stubs ? Yes, ideally we'd be able to use [stubgen (a tool packaged with mypy)](https://mypy.readthedocs.io/en/latest/stubgen.html), to...
@sdaftuar with your latest push: ```bash headerssync.cpp:41:46: error: invalid operands to binary expression ('NodeClock::time_point' (aka 'time_point') and 'int64_t' (aka 'long long')) m_max_commitments = 6*(GetAdjustedTime() - chain_start->GetMedianTimePast() + MAX_FUTURE_BLOCK_TIME) / HEADER_COMMITMENT_PERIOD;...
> I could test if it was a change possible to test with windows binaries built using instructions in https://github.com/bitcoin/bitcoin/blob/master/doc/build-windows.md It is. Run `make deploy` and that will build the...
> Should the 24.0 milestone be assigned here? I don't think this needed a milestone, but is going to be merged now in any case. I'll combine some other minor...
ACK > What do we gain from this? Using the standard library over a third party dependency.
Fixing these warnings is fine, they've been around forever. However concept NACK on the approach. Similar to #23612, creating (undocumented) special-cases in depends, should be a last resort, especially if...
> Got it. Just a note that a similar approach is already used: Yes, however always turning off reduced exports when debugging, isn't really the same as turning it on...
> dongcarlvfanquake ryanofsky theuni > Your conceptual assessments of this PR will be much appreciated. I am a Concept ~0/ACK for CMake. However I think if we are going to...
> Don't some depends users want to build using those system libs (while using depends for other stuff)? Only if you explicitly opt in. That shouldn't be the default behaviour...
Doing a depends build of 156afca1c03e2688417d1da313a475e58260d4ac, on aarch64 Linux, currently fails with: ```bash make -C depends -j9 NO_QT=1 NO_WALLET=1 NO_ZMQ=1 NO_UPNP=1 NO_NATPMP=1 CC=clang CXX=clang++ cmake --toolchain depends/aarch64-unknown-linux-gnu/share/toolchain.cmake -S . -B...