fanquake

Results 881 comments of fanquake

> What was your intention with this patch, @fanquake ? At this point I can't remember.

> I think we should first prioritize coordinating the optimization and debugging flags between the depends subsystem and the main build system: I'm not sure? This hardening feature should be...

> Not sure if this makes sense, but if the problem is that specifying _FORTIFY_SOURCE without optimizations triggers a compiler warning, maybe there should just be a check that drops...

> Resolves https://github.com/bitcoin/bitcoin/issues/30876. Not sure it does, as that issue applies to all dependencies, not just ZMQ.

Concept ACK - Tested this (rebased) branch on Alpine, which ships pkg-config files and CMake config files for ZeroMQ. ```bash cmake -B build -DWITH_ZMQ=ON -- Found ZeroMQ: /usr/lib/cmake/ZeroMQ (found suitable...

We should also follow up with refactoring the libevent module, to more generically use CMake/pkg-config, rather than restricting the CMake usage to `vcpkg`. At that point, we'd likely be able...

> could we add a safety harness to make sure it's never being used accidentally for a live node? > Maybe somewhere in init.cpp or bitcoind.cpp: > Edit: I realize...

> Do you have an example what the before and after of this change looks like? The before is: ![before](https://github.com/user-attachments/assets/d67e6819-e65f-4cca-9f78-61d7b4cb143f) So I think pointing to an image that exists will...

In that case, maybe it's actually just best to leave it as-is for now.

@theuni just cleanup atm.