Eric Nordelo

Results 99 comments of Eric Nordelo

Closing as the doc site is part of a different repo now.

Closing because we won't have a callback function. I still think at least Beacon Proxies might be helpful. We will open an issue for it if we find demand.

Hey @FabijanC, thanks for your interest in contributing! We haven't decided if we want to remove this constant in this particular issue since it might be helpful as a reference...

Sure! Check the [good first issue](https://github.com/OpenZeppelin/cairo-contracts/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22good%20first%20issue%22) label

Closing this as it is not widely adopted. Feel free to reopen the discussion if you think otherwise.

Hey @virajbhartiya. Thanks for your interest in contributing! We plan to take this particular issue since it involves careful design around the API of the solution. I recommend you to...

Hey @immrsd. Can you please format the files and go through the pending previous review comments before I give this a second pass? Thanks!

Great job @immrsd. The PR looks great, the only thing as I mention below is that adding clock_mode to Timelock as well is not a requirement for this issue, so...

This should give a compilation error from the Component being imported twice. I think we should avoid front-running compilation errors, to maintain the macro as simple as possible.