cairo-contracts icon indicating copy to clipboard operation
cairo-contracts copied to clipboard

Document account component utils in docsite

Open andrew-fleming opened this issue 1 year ago • 2 comments

andrew-fleming avatar Jun 17 '24 21:06 andrew-fleming

Hello @ericnordelo , I want to fix this issue, Can I get assigned for this?

markv44 avatar Apr 03 '25 09:04 markv44

Hey @markv44. Feel free to open a PR; we will be happy to review it!

ericnordelo avatar Apr 03 '25 12:04 ericnordelo

gm, would love to take a shot at this. I recently contributed to the SN Foundry docs as well.

Shall I submit a PR for you to review if this is still open?

JJScar avatar Jul 08 '25 08:07 JJScar

Hey. Sure, feel free to open a PR and I will be happy to review it. Note that we have a deploy preview action here in GitHub that will redirect you to netlify, and you can also run the doc-site locally. If the changes look broken in the doc-site, is hard for us to go through the content, so I suggest to get that covered as you work on it. Thanks and happy contributing!

ericnordelo avatar Jul 08 '25 12:07 ericnordelo

Ok perfect. I am on it. Just to make it clear so I don't make mistakes. Are we talking about the file utils.cairo, or the folder utils the has the secp and sig files? Or both?

JJScar avatar Jul 08 '25 13:07 JJScar

Both should be documented as long as they are part of the public API.

ericnordelo avatar Jul 09 '25 10:07 ericnordelo

Published PR #1465

Let me know if anything needs to be modified extra!

This was cool never played with Antora before. Neat!

JJScar avatar Jul 09 '25 11:07 JJScar

Closing as the doc site is part of a different repo now.

ericnordelo avatar Nov 12 '25 19:11 ericnordelo