Eric Nordelo

Results 99 comments of Eric Nordelo

Rules for test assertions: - Use assertion macros instead of inline functions (`assert!` and `assert_eq!`). These allow us to pass ByteArrays instead of short strings. - Use `assert_eq!` over `assert!`...

We don't need the message to spot the line, by default we have test name + the assertion failed, and I think that's enough (even more if the assertion naming...

Hi @marlon-wiprud, a workaround until an update is released is to change the name of the file containing the interface to something not finished with Account (so starknet compiler doesn't...

Hi @aconrad. I've just seen colors only in the diff command, not in the show command, am I missing something?

I'm thinking of color by row, not by column. For example, red row if coverage is under 60 percent, yellow row if coverage is between 60 and 80, and green...

This PR adding the ability to have mock contracts only built when running tests will be beneficial for OZ users since now we have migrated to starknet foundry and had...

This issue can be extended to have a proper deployment system to be able to define and re-execute flows, but that is certainly bigger and can be implemented with plugins.

Hi @ElijahVlasov! Thanks for taking the time to contribute to Nile! For a PR to be merged, please first [check the CONTRIBUTING guide](https://github.com/OpenZeppelin/nile/blob/main/CONTRIBUTING.md) in the repo, for some guidelines contributors...

Hi @potti. That's an issue coming from starknet-devnet installation. The current starknet-devnet version only supports python until 3.9, and you are using 3.10.