cairo-contracts icon indicating copy to clipboard operation
cairo-contracts copied to clipboard

SNIP-64: Custom Errors for ERC20 and ERC721

Open zpano opened this issue 1 year ago • 2 comments

🧐 Motivation Specification error message

📝 Details Ref: https://github.com/starknet-io/SNIPs/blob/main/SNIPS/snip-64.md Refactor every contract error's definition

zpano avatar Apr 17 '24 14:04 zpano

I'm interested in contributing and would like to know if there is a link or resource that captures previous discussions or decisions on this issue. This would help me understand the current status and next steps

sprtd avatar Sep 20 '24 00:09 sprtd

Hi @sprtd thanks for your interest in contributing! We are still discussing wether we want to implement this(but have decided not to do it in the short term). We still need to evaluate a few things:

  • How much adoption does the SNIP have?
  • What are gas cost implications of doing this formatting
  • This is a breaking change since it changes the API of the contracts, which are ones of the most widely used in the library. We need to communicate in anticipation this change.

If you have thoughts about any of this or have seen demand feel free to leave it in the comments. In the meantime if you see any other issue that is a good fit feel free to let us know :)

ggonzalez94 avatar Sep 25 '24 14:09 ggonzalez94

Closing this as it is not widely adopted. Feel free to reopen the discussion if you think otherwise.

ericnordelo avatar Nov 12 '25 19:11 ericnordelo