cairo-contracts icon indicating copy to clipboard operation
cairo-contracts copied to clipboard

Macros: Prevent duplicates

Open immrsd opened this issue 4 months ago • 2 comments

Although duplicated components anyway result in compilation error, I think it can be helpful to add the check and corresponding error message

immrsd avatar Aug 20 '25 11:08 immrsd

This should give a compilation error from the Component being imported twice. I think we should avoid front-running compilation errors, to maintain the macro as simple as possible.

ericnordelo avatar Aug 20 '25 11:08 ericnordelo

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 92.35%. Comparing base (f301f03) to head (5fd8a8d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1508   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files          82       82           
  Lines        2264     2264           
=======================================
  Hits         2091     2091           
  Misses        173      173           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f301f03...5fd8a8d. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 20 '25 11:08 codecov[bot]