Eric Nordelo

Results 99 comments of Eric Nordelo

Hey @gerceboss, sorry for being this late to the conversation. I reviewed the PR and the implementation, tests, and docs look great. With this said, I think that for this...

> I lean toward keeping the component light and not introduce non-core impls directly. The additions are small, but it forces all contracts to add extra storage for a feature...

Hi @xJonathanLEI. Is there an ETA for implementing the Decoder? I see there is an issue open for it, but I don't see much activity.

Completed as part of #1116

Hey @zpano, thanks for taking the time to contribute. Note that we expect the PR to contain a strong test suite before reviewing it, and documentation before merging it.

Closing as we already merged VestingComponent in #1116

Hey @swan-of-bodom, 6909 is not part of our roadmap short term, but I think it could be a great addition. Happy to review and support a PR for including it...

Hey @boray thanks for taking the time! This would be a nice addition and we are happy to merge it after is finished and reviewed. We will be happy to...

Hey @ametel01, this PR is from an external contributor, and we will be happy to review it and merge it as soon as it is ready, It is also part...

We will start working on it right after finishing this release. The reason is mainly [these changes](https://github.com/OpenZeppelin/cairo-contracts/pull/1065) that conflict and must be included first.