Eric Nordelo

Timestamp-based Governor

1

**🧐 Motivation** I'm using your Governance implementation, and I want to check proposal deadlines with Timestamps instead of Block Numbers. Currently, you have a hardcoded Timer.BlockNumber in the ProposalCore struct...

Enable timestamp-based governor with choice of timer type

12

Fixes #3081 #### PR Checklist - [x] Tests - [ ] Documentation - [ ] Changelog entry

running evm printer leads to "ValueError: too many values to unpack (expected 4)"

1

Traceback (most recent call last): File "/home/ericng/.local/lib/python3.8/site-packages/slither/__main__.py", line 741, in main_impl ) = process_all(filename, args, detector_classes, printer_classes) File "/home/ericng/.local/lib/python3.8/site-packages/slither/__main__.py", line 83, in process_all ) = process_single(compilation, args, detector_classes, printer_classes) File...

This level shows the user that Reverts Errors can be simulated from the call stack (bubbled-up), potentially provoking unexpected behavior if the developer assumes that the Error comes from one...

Fixes #455 #### PR Checklist - [ ] configure test coverage check on CI - [ ] add test coverage badge on README

- [ ] Add and update tox entries. - [ ] Update CI (add checks) - [ ] Update CONTRIBUTING guide.

Allow query calls in Account

3

Fixes #471 Allow transactions with version equal to the current Starknet QUERY_VERSION. - [x] Tests - [x] Tried the feature on a public network

Standardize format for library error messages

1

Currently, we have some small inconsistencies like `Account: no reentrant call` and `ReentrancyGuard: reentrant call`, that is, for example, an inconsistency between **describing the expected behavior** vs **describing the issue**....

Error compiling IAccount.cairo

1

Trying to compile with `nile compile --directory src` raises the following error: ``` Compiling src/openzeppelin/account/IAccount.cairo Account contracts must have external functions named {'__validate_declare__', '__validate__', '__execute__'}, found: []. ```

Use initializable library inside other libraries

5

For example in upgrades library: https://github.com/OpenZeppelin/cairo-contracts/blob/b764660da224ee757b831ea62bf7a4c63ee898fb/src/openzeppelin/upgrades/library.cairo#L44-L55 Wouldn't be better to import and using here the initializable library instead of rewriting the initialization logic? I think importing libraries from libraries is...