Eric Nordelo

Results 99 comments of Eric Nordelo

Hey @markv44. You can check how the docs would look by going to the Deploy Preview action executed in the PR for the latest commit. If you go there, you...

Hey @markv44, on the same page where you added the Account Utilities there are examples on how to use the attributes in the right way.

Hey. Tests should be fixed if you merge main into the PR, since the issue is with the new version of foundry. If you go to the deploy preview, though,...

> I think we can update [Creating a token receiver contract](https://github.com/ericnordelo/cairo-contracts/blob/feat/document-erc721receiver-%23913/docs/modules/ROOT/pages/erc721.adoc?plain=1#L214-L223) to use ERC721ReceiverMixinImpl as well to clean up the snippet. WDYT? The only issue I see with the approach...

Hey @turkaturki. Thanks for your interest in contributing to the library. Feel free to work on this and open a PR; we will happily review it.

Currently, we test that events are emitted correctly for our components, and we check that the members match the expected format. The issue is that we are not testing that...

Thanks for the interest in contributing! We are always happy to review PRs and try to keep a list of good first issues. For this particular one, we already have...

Hey @xJonathanLEI! Thanks for opening the issue. This is certainly interesting and we will add it to the roadmap. Feel free to open a PR if you feel like contributing,...

Hey @xJonathanLEI I'm curious about if this is already natively integrated in starkli and what was the solution. Do you think is worth adding a preset using SNIP12 for to...

Makes sense. Closing the issue from that information. Feel free to reopen it if you see there's more to discuss about.