Binbin comments

Results 276 comments of


                                            Binbin

Rename redis.tcl to valkey.tcl

i have seen some PRs doing this rename things (like #287). since now that we have started, let's rename them all in tcl tests. personally, i want to do this...

Introduce `commandlog heavytraffic` to record big response packet.

+1 on "LARGELOG"

Update lateny report output message

> I'm a little sad to remove the Dave dialog. It's a reference to the film 2001 A Space Odyssey. Have you watched it? It's a brilliant film from early...

Make cluster replicas return ASK and TRYAGAIN

i guess we also need to update https://valkey.io/commands/readonly/

Make cluster replicas return ASK and TRYAGAIN

ohh, so in the docs, we already says that the replica can return redirects (before the changes)...

Make cluster replicas return ASK and TRYAGAIN

> Yes, but maybe we should add a note like "Before Valkey 8, it was not reliable during slot migrations bla bla bla....." WDYT? yean, this is a sometime that...

Make cluster replicas return ASK and TRYAGAIN

@zuiderkwast ping, i need an ACK in case i misunderstood it

[NEW] Handle spamming of custom LUA error messages in the INFO ERRORSTATS section with continued tracking of non LUA errors stats

does this https://github.com/redis/redis/pull/13141 can somehow solve your problem?

[NEW] Handle spamming of custom LUA error messages in the INFO ERRORSTATS section with continued tracking of non LUA errors stats

> I really don't understand why Oran marked that as not a breaking change, it's possible someone had more than 128 errors. yes, that is indeed a potential breaking change....

[NEW] Handle spamming of custom LUA error messages in the INFO ERRORSTATS section with continued tracking of non LUA errors stats

> Yes, looks like with the current implementation (from https://github.com/redis/redis/pull/13141): > 1. To re-enable error stats tracking, we need to use CONFIG RESETSTAT which will clear command stat counters and...