Binbin
> I'm kind of okay with the tradeoff that https://github.com/valkey-io/valkey/pull/500 proposes, we continue to report normal errors but we stop reporting LUA errors. yean, i am ok with that.
sorry, i just merged #949 since Wen did a fresher review, i didn’t notice this PR...
@DarrenJiang13 Hi, sorry for the late repsonse, would you be able to refresh this PR?
please sign the DCO
I think one PR should be enough, there is no need for more batches, please go ahead, thanks
CI report some failure, please take a look: https://github.com/valkey-io/valkey/actions/runs/11716457128/job/32634549755?pr=515#step:4:560 ``` sed '/Everything below this line/,$d' fmtargs.h > fmtargs.h.tmp /usr/bin/python3 ../utils/generate-fmtargs.py >> fmtargs.h.tmp mv fmtargs.h.tmp fmtargs.h CC server.o server.c:6799:19: error: ISO...
i see daily.ci is still have some `valkey-server test all`, please also remove it, and also use the new `./src/valkey-unit-tests` to replace it. please also remove all `DSERVER_TEST`
I see the top comment is outdated, could you please update the top comment to reflect the changes? And then i believe we are good to go.
thank for the report. I think https://github.com/valkey-io/valkey/pull/879 can fix it. I will check it later edit: i see the PR does not cover this case, i will handle it later
@PingXie in this case, the primary is cluster-allow-replica-migration no and its replica is cluster-allow-replica-migration yes, during the migration: 1. primary calling blockClientForReplicaAck, waiting its replica 2. its replica reconfiguring itself...