Binbin

Results 276 comments of Binbin

> the connection is not in a pubsub mode, so it should reply with a plain error, and not with a pubsub type message. trying to pick this up, it's...

It appears to be a known situation, breaking change ``` test "UNSUBSCRIBE from non-subscribed channels" { set rd1 [redis_deferring_client] assert_equal {0 0 0} [unsubscribe $rd1 {foo bar quux}] # clean...

do we need to add reply_schema for command.json? (the same reply as COMMAND INFO)

we can just set the value to -1 if you think the value is meaningless. since it is a debug command, I don't care about its meaningless values ​​in other...

> I hereby officially transfer the copyright ownership of this logo artwork (originally https://github.com/valkey-io/valkey-website/issues/7#issuecomment-2033284794) to the Valkey project. @dizys thank you so much, we all like that logo.

I also noticed, reproduced before, but it didn't stop there with `--stop` option i tried adding something (something like --stop) early to see if I can reproduce it locally. i...

@oranagra @zuiderkwast I successfully reproduced the problem, this payload: ``` restore key 0 "\x14%%\x00\x00\x00\n\x00\x06\x01\x82_5\x03\x04\x01\x82_1\x03\x82_3\x03\x00\x01\x82_9\x03\x82_3\x03\b\x01\x02\x01\xff\x0b\x001\xbe}A\x01\x03[\xec" replace [root@binblog redis]# src/redis-cli smembers key 1) "6" 2) "_5" 3) "4" 4) "_1" 5) "_3"...

I once wanted to add a force option to script kill

I think it’s better to keep the redis style `MOVE key db`. If we specifially need such a feature, we should add a new command, or at least do it...

Personally, i don't like ths switches thing, once it is added we have to live with it for a while (years). and then i worry we'll never get out of...