Binbin
Looks like it could be a complement to SCHEDULE. I am ok with both. Another question here, `kill the current running bgsave`, does it include the disk-based replication or the...
look good to me. That's also what i thought. Let's also make sure we won't kill the replication fork? Since it is a bgsave command, i think we should let...
full ci: https://github.com/valkey-io/valkey/actions/runs/10389867384
LGTM, @zuiderkwast @PingXie any other ideas before the merge?
@madolson @zuiderkwast @PingXie do you guys want to takes a look with this? i would like to include it in the RC3
ok, i see the point, indeed in this case, we need to find a way to re-open the file.
thanks for doing this pic, it look clear. i vote for the option 1, we keep the old cluster way and also make standlone to be the same way
I mentioned here https://github.com/valkey-io/valkey-doc/pull/158 wanting to add these fields, and now seems like a good time to do it. @valkey-io/core-team please take a look at the doc PR link, and...
I think both cases can happend, as long as the situations will cause diskless-sync fail, we should set the repl-diskless-sync-status.
@valkey-io/core-team please take a look and check if this needs to be fit into 8.0 Here are the fields we have now and their definitions, we can see we are...