valkey icon indicating copy to clipboard operation
valkey copied to clipboard

Update lateny report output message

Open hwware opened this issue 1 year ago β€’ 9 comments

  1. Update "Redis" to "Valkey"
  2. Remove Dave dialog, and update to normal output message

I think this should be not break change.

hwware avatar May 02 '24 18:05 hwware

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 68.43%. Comparing base (443d80f) to head (d555d30).

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #426      +/-   ##
============================================
- Coverage     68.44%   68.43%   -0.01%     
============================================
  Files           109      109              
  Lines         61671    61671              
============================================
- Hits          42212    42206       -6     
- Misses        19459    19465       +6     
Files Coverage Ξ”
src/latency.c 81.49% <42.85%> (ΓΈ)

... and 13 files with indirect coverage changes

codecov[bot] avatar May 02 '24 18:05 codecov[bot]

I'm a little sad to remove the Dave dialog. It's a reference to the film 2001 A Space Odyssey. Have you watched it? It's a brilliant film from early time, 1969 IIRC. The computer talks to the crewman Dave on a space ship.

wow, i haven't watched it, don't know the history. I did a search and it looks like a very exciting film. Can't imagine a movie this old, i am going to add it to my list and then try to find time to take a look.

If that's the case, I think maybe we can keep it? It seems that the modification is not particularly important, but it seems to be very memorable.

enjoy-binbin avatar May 07 '24 04:05 enjoy-binbin

https://youtu.be/Mme2Aya_6Bc

https://youtu.be/twTESNFc1ww

zuiderkwast avatar May 07 '24 05:05 zuiderkwast

@madolson Let's keep the Dave dialog?

zuiderkwast avatar May 07 '24 05:05 zuiderkwast

I'm a little sad to remove the Dave dialog. It's a reference to the film 2001 A Space Odyssey. Have you watched it? It's a brilliant film from early time, 1969 IIRC. The computer talks to the crewman Dave on a space ship.

Sorry, I never see this movie. Now i know where Dave comes from, I am just curious why Dave here. @madolson DO you think we should keep Dave here?

hwware avatar May 07 '24 13:05 hwware

I have had more than one conversation with someone asking who "dave" was, and then I had to explain to them how it's a reference to 2001 a space odyssey, and then they told me they have never heard of the movie. Some of them are also weird, like "I honestly think you ought to sit down calmly, take a stress pill, and think things over". I think someone might take that the wrong way.

"I'm sorry, Dave, I can't do that." Is the iconic line, it's also on an error path since latency is disabled. So I guess my vote is let's just keep that one and delete all the other references.

madolson avatar May 08 '24 19:05 madolson

I'm fine with removing most of these, if the rest of you want that.

"I honestly think you ought to sit down calmly, take a stress pill, and think things over"

This one is in the 2nd of the two youtube videos I posted above.

zuiderkwast avatar May 08 '24 21:05 zuiderkwast

This one is in the 2nd of the two youtube videos I posted above.

I had seen the movie and had no recollection of that phrase πŸ˜“. If other people do think it's popular, I would be fine keeping it, I just do think it's much less more recognizable than the "I can't do that" line.

madolson avatar May 13 '24 00:05 madolson

Can we agree on keeping only one "i can't do that dave" and delete the others? (πŸ‘ = yes)

zuiderkwast avatar May 13 '24 17:05 zuiderkwast

Replaced by #644

zuiderkwast avatar Jun 14 '24 10:06 zuiderkwast