Binbin comments

Results 276 comments of


                                            Binbin

Strictly check CRLF when parsing querybuf

> I looked at the test failures and it does not seem to be related. @enjoy-binbin lets go ahead with merging it WDYT? yes, SGTM.

[NEW] Add Dedicated Metrics for Expiration Table Lazyfree Monitoring

I don't think we will do this, there is no enough arguments to do it. @zuiderkwast Do you want to comment this one?

Fix AOF rewrite and restore BF tests

@arpitbbhayani can you fix the DCO?

Save cluster file in bio to avoid the stuck io latency

@cherukum-Amazon sorry for the dealy, i somehow lost the context a while ago, i will try to refresh it this week. Let's start working on #1032 first and try to...

Check for duplicate nodeids when loading nodes.conf

> This is very unusual? Only human edited nodes.conf and similar errors? yes, i did manually edited and test it locally, and the node attributes were overridden in various ways....

[CRASH] Crash in Valkey 8.0.3 during downgrade from Valkey 8.1.0

I forgot the details, it is weird that i did not write a test (i normally do). I will think about the test when i full more time in the...