Binbin

Results 276 comments of Binbin

Yep Not problem. I understand it is risky Or maybe we should just print some logs to help the user for debug

Right. I can give a try. Thanks @arcivanov

@arcivanov I add a discard_logs_on_reconnect_error setting default false. Maybe not good enough

Is it stable? can you run a few more times, some tests are more sensitive, and we did not see it in recent times

here is the RESP2 output: ``` 127.0.0.1:6379> UNSUBSCRIBE a b c 1) "unsubscribe" 2) "a" 3) (integer) 0 1) "unsubscribe" 2) "b" 3) (integer) 0 1) "unsubscribe" 2) "c" 3)...

@MeirShpilraien when you have time, take a look with this one (FUNCTION INFO fields), it is hard for me to track the changes...

reported in https://github.com/redis/redis/runs/7869289433?check_suite_focus=true#step:4:6755:

thanks for reporting, indeed a bug (redis-cli bug), i tested in unstable branch

> it seems like the protocol is broken by the UNSUBSCRIBE command (returning multiple RESP replies). and it seems to have existed in previous versions as well. yes and yes,...

yes, think again now, i agree with oran. the connection is not in pubsub mode, and i guess reject these command is the better way to go