Rename redis.tcl to valkey.tcl

[hwware]

Test passed.

[hwware]

valkey.tcl defines a lot of functions and structures called redis. This is just confusing. If we rename the client lib, rename the functions and types to valkey too, or otherwise just leave it with the name redis.

In this file, a lot of proc and global variables are defined by redis* name. In fact, we can rename all of them to valkey*, do you think this is a branding name issue or just leave them as a redis legacy?

[zuiderkwast]

Yes, I think it's a good idea to rename all redis to valkey in the tests. It is safe and the code will still work. Just don't change redis in copyright and license text in the files.

I don't think there is a trademark issue at all in the tests. We can keep "redis" if we want. The only reason to change it is that it is nice to remove it. Do you think it's better to just keep "redis" everywhere in the tests?

[enjoy-binbin]

i have seen some PRs doing this rename things (like #287). since now that we have started, let's rename them all in tcl tests.

personally, i want to do this in a big PR so that we don't have a lot of commits. Changing it is very simple, it only needs to pass CI and does not require much review. But i am ok with spitting it into multiple small PRs.

[zuiderkwast]

I like @enjoy-binbin's suggestion of one big PR for all TCL tests. If we change exactly everywhere, theoretically everything should work.

"Redis" -> "Valkey"
"redis" -> "valkey"
"REDIS" -> "VALKEY"

[zuiderkwast]

This is part of #155 but i see no link between issue and pr.

[zuiderkwast]

This PR is outdated now after #287 was merged.

#287 changed everything inside the test files, but it didn't rename the file redis.tcl to valkey.tcl. We still need to do that.

The changes in tests/README.md are also good.

@hwware do you want to update this PR?

[hwware]

This PR is outdated now after #287 was merged.

#287 changed everything inside the test files, but it didn't rename the file redis.tcl to valkey.tcl. We still need to do that.

The changes in tests/README.md are also good.

@hwware do you want to update this PR?

let me refresh it. Thanks

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.37%. Comparing base (8baf322) to head (c8dace1).

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable     #283      +/-   ##
============================================
- Coverage     68.40%   68.37%   -0.04%     
============================================
  Files           108      108              
  Lines         61562    61562              
============================================
- Hits          42113    42093      -20     
- Misses        19449    19469      +20     

see 13 files with indirect coverage changes

[hwware]

This PR is outdated now after #287 was merged.

#287 changed everything inside the test files, but it didn't rename the file redis.tcl to valkey.tcl. We still need to do that.

The changes in tests/README.md are also good.

@hwware do you want to update this PR?

Rebase done, and pass all tests, pls take a look, Thanks