Binbin

Results 276 comments of Binbin

cant we execute module unload + module load in a multi? > Some module clients do not want to restart the server to use new arg, they want to dynamic...

This is a good idea. In my fork, i have a similar feature like this (detect a disk error and do failover). The basic idea is that, the primary will...

> The primary first pauses writes, then waits for the replica to replicate everything and then sends CLUSTER FAILOVER FORCE. yeah, this seems ok to me, faster. This different i...

i dont have enouth time to write the test right now, i guess you might want to take a look at it in advance, so here is the commit https://github.com/enjoy-binbin/valkey/commit/9777d01084ea8c1f91e3c1c2b43123711392a472...

haven't find time to come back here lately, will pick it up again next week

I thought we were abandoning sentinel, i am ok with both though, as long as there is value in it, i think we can also support it.

> When a slot migration is complete, the cluster bus propagates the new ownership of the slot to all nodes in the cluster. When this information reaches a replica with...

The 30 second demo thing look cool, but i don't like this kind of fancy stuff on projects

I haven't seen this test fail in a long, long time. (It was hardened a long time ago by me and oran)