valkey icon indicating copy to clipboard operation
valkey copied to clipboard

Document the clang-format flow in CONTRIBUTING.md

Open SoulPancake opened this issue 1 year ago • 5 comments

Solves #649.

SoulPancake avatar Jun 17 '24 13:06 SoulPancake

@PingXie Can you please take a look ^_^

SoulPancake avatar Jun 17 '24 13:06 SoulPancake

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.19%. Comparing base (5a51bf5) to head (855b2b9). Report is 17 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #659      +/-   ##
============================================
+ Coverage     70.17%   70.19%   +0.01%     
============================================
  Files           110      110              
  Lines         60077    60078       +1     
============================================
+ Hits          42160    42171      +11     
+ Misses        17917    17907      -10     

see 14 files with indirect coverage changes

codecov[bot] avatar Jun 18 '24 03:06 codecov[bot]

I was wondering if we can do something like the following for the installation steps https://github.com/jdx/mise?tab=readme-ov-file#30-second-demo

@PingXie @madolson @enjoy-binbin @hwware Would like to know your thoughts

SoulPancake avatar Jun 27 '24 08:06 SoulPancake

The 30 second demo thing look cool, but i don't like this kind of fancy stuff on projects

enjoy-binbin avatar Jun 27 '24 10:06 enjoy-binbin

I was wondering if we can do something like the following for the installation steps https://github.com/jdx/mise?tab=readme-ov-file#30-second-demo

The 30-second demo GIF makes sense for a dev tool project to show users how it makes the workflow smooth. However, including it as part of a contributing document may not be particularly useful. :thinking:

haoqixu avatar Sep 09 '24 10:09 haoqixu