Binbin
> So when they have some very slow lua script, etc. they increase the node timeout to compensate? No, they usually don't know that they will send slow commands in...
Speaking of node timeout. Or, if a node is blocked in a slow command, is it really dead? I have also seen some users who just need to execute slow...
> 500 + /* Fixed delay of 500 milliseconds, let FAIL msg propagate. */ I see one of the 500, the main purpose is to propagate the FAIL so that...
> When node timeout is 1 second, this 500ms is significant. Make sense, just curious, what is the minimum timeout you have set in the real world? > I think...
I think i got a hint. I will work on it this weekend
Great, a FORCE LGTM, i think we can do it. btw, lets also talk about https://github.com/valkey-io/valkey/pull/866#issuecomment-2290542519? Currently to ensure script atomicity, we can bypass maxmemory (data memory or lua heap...
> To return OOM early is an automatic kill, not SCRIPT KILL, right? yes, it is an automatic kill. There are always people messing around with scripts... We will give...
I'm going to throw out a case that will now cause data inconsistency ``` start_cluster 3 3 {tags {external:skip cluster} overrides {cluster-replica-no-failover yes}} { test "test" { r config set...
yes, i am working on a fix
I put the fix I wanted to make here, https://github.com/valkey-io/valkey/pull/2157