Binbin

Results 276 comments of Binbin

Example: ``` Starting 30001 Starting 30002 Requested to create a cluster with 1 primaries and 1 replicas per primary. Valkey cluster requires at least 3 primary nodes for automatic failover....

@valkey-io/core-team not sure if this is a major decision, but please take a look when you guys has time.

> Now can we create a cluster with 1 or 2 primaries in production? yes, we can. You can write you own script or just start a node and then...

Ok, with the grea explanation by zuiderkwast above, i don't think this will be a major decision, and now I often use it to quickly create clusters for testing, and...

CI link: https://github.com/valkey-io/valkey/actions/runs/11028380661/job/30628495083?pr=1073#step:5:3785 ``` [exception]: Executing test client: ERR Master is down or failed, please use CLUSTER FAILOVER FORCE. ERR Master is down or failed, please use CLUSTER FAILOVER FORCE...

@PingXie Do you have time to check this out? (Or just simply approve it since it is not easy to figure out the test) We used to have frequent test...

@zuiderkwast This is quite small, do you want to review it?

so what caused the 40% improvement? you use a huge io-threads number, but it stops because there are fewer pending requests? I remember it would stop because it felt that...

Sorry i missed the thread. And yes, i think we indeed can adjust the number. In #1018, i use the same 500 number to add the delay by default to...

> Just an idea: node_timeout / 30. If gives us 500 for the default node timeout 15000. > For node timeout 3000, we get 100 ms. Seems ok? this looks...