Binbin

Results 276 comments of Binbin

> But if this implementation to wait for the vote will be too complex, then let's just skip the vote. I think it's also fine. Without this feature, we wait...

> CLUSTER FAILOVER REPLICAID node-id can also be sent to a primary now? It replicates it and the replica will do the failover, right? no, we won't replicate this command....

right, i totally forgot it. I guess it might be the difference between active and passive? auto-failover-on-shutdown (and shutdown-on-sig failover for sure) is like a passive way, and SHUTDOWN FAILOVER...

I added debug command locally to verify this problem, ping me if you think we should add a test to cover it.

yes, i think we should backport it to 8.0. I want to wait for @PingXie to take a look before merging

in cluster we have this data_age, this in some cases will casue the data_age too old issue, i somehow forget the details, but i think we do need combine these...

> source (parent) forks a child with a set of slots to migrate child streams slots to be migrated in the RDB format (same as replication) target needs to support...

Another approach is that we only update conf to mention the effect of hz. In addition, i will mention these things we've discussed in the old times: 1. add active_rehashing_cpu_milliseconds...

The doc is great, i will take it, thanks. > I like the idea of active-rehashing-effort, since it is kind of similar to expire-effort. So maybe we should already now...

`active-rehash-cycle` just a CPU cycle [1, 49], default is 1. Users can control how many cycles to use in activerehash, but i can see it is hard to decide the...