Binbin
> A basic idea is that each node remembers what it sent to any other node (for example a hash of the content) and if it hasn't changed since the...
that will be great if we next time, when doing the rebase merge, we squash the PR number like #2089 in the commit message title. (I usually locate the PR...
so module auth can add reply in its callback, or not add reply and just return an err robj in its callback? And we have to figure a way to...
deferred_reply_errors wont work since it is only used for module command i guess, in this auth command it does not trigger it. Another ugly way is, check and see if...
so i think we should return an error when `client unblock` with a `BLOCKED_POSTPONE` client since we don't have a timeout callback for this case? Or just return 0 when...
> Emphasis? Maybe, but why emphasis this word? Very strange. i guess it is just a habit from oran. Something like a modal word. Ok, i am good with merging...
`#define thread_local _Thread_local` seems to work in my machine (mac M3)
@jwakely do you think a `#define thread_local _Thread_local` is enough for this case? I tested it in some CI look like that all can pass the build, do you want...
ok, in your environment, the nodes will frequently enter and exit the pfail/fail state? The main reason i made this change was to better track changes in node state.
> My concern is with cluster of large size, this log statement becomes quite ineffective by logging for each primary's report and can cause spikes in CPU utilisation. Have you...