Binbin

Results 276 comments of Binbin

> 问一下,提交.c文件,它对应的头文件需不需要一起提交,还是分成两个PR 属于同一个主题一起提交就好 我看到 diff 里有包含 rio 相关的内容,可以 rebase 一下最新代码吗

不是 是和本仓库的主分支,例如你的 rio PR 已经先合并了,然后你这个 cluster PR 里包含了 rio 的内容 (已经被合并过的,或者新加的)

@oranagra @yossigo i tested with this change, and it will work, i also triggered a daily CI, it passed hope I did it right (about the connection part), looking forward...

i will try to add some tests later, but for now, i will submit the PR first. The RDB part mentioned in #9991, i did test it in local, it...

> haven't reviewed the code in detail yet, but what if a BGSAVE or AOFRW process repeatedly fails (e.g. disk access error), and that can starve a replica (possibly a...

yes, you are right, that is my thought > if it fails, the fact that the dirty counter is still high, will not give it a priority over replicas (since...

yep, i think we can update it and merge it

It seems like a nice feature, and i see a lot of thumbs up. @oranagra WDYT?

They are all optional, when not passed in, the effect is the same as before

i tested it in 5.0.14 (both cli and server), it work and then it looks like it's broken since 6.0 (redis-cli) i can take a look when i have times