Fix CLUSTERDOWN issue in cluster reshard unblock test

Open enjoy-binbin opened this issue 3 years ago • 1 comments

A timing issue like this was reported in freebsd daily CI:

*** [err]: Verify command got unblocked after resharding in tests/unit/cluster/cli.tcl
Expected 'CLUSTERDOWN The cluster is down' to match '*MOVED*'

The reason is, in clusterRedirectBlockedClientIfNeeded (which is called by clientsCron), it is possible for the client to unblock because of CLUSTERDOWN, depending on the cluster state when clientsCron is called. In this fix, we assert MOVED or CLUSTERDOWN to verify that the client is unblocked. And additionally fix some typos.

Aug 17 '22 03:08 enjoy-binbin

reported in https://github.com/redis/redis/runs/7869289433?check_suite_focus=true#step:4:6755:

Aug 17 '22 03:08 enjoy-binbin